Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyomo.DoE: Handle edge case where the nominal value for a parameter is zero #3530

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adowling2
Copy link
Member

Fixes # .

Summary/Motivation:

  • If a parameter has a nominal value of zero, we will get a divide by zero error when calling compute_FIM

Changes proposed in this PR:

  • Added a minimum step size for perturbation.

TODO Before converting from draft

  • Finish edits and debug
  • Decide where to add check to throw error if we try to use parameter scaling and a parameter is zero
  • Add tests to check this edge case include any new error message
  • Update documenation (minor)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adowling2 adowling2 marked this pull request as draft March 20, 2025 23:43
@adowling2
Copy link
Member Author

@djlaky @smondal13 @sscini FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant